Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mimecast parsing #1420

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Improve Mimecast parsing #1420

merged 5 commits into from
Jan 9, 2025

Conversation

TonioRyo
Copy link
Collaborator

@TonioRyo TonioRyo commented Jan 7, 2025

  • Extract email subject
  • Extract URL from rejection info

@TonioRyo TonioRyo requested a review from a team January 7, 2025 12:27
Copy link

github-actions bot commented Jan 7, 2025

Smart descriptions generated from the latest tests at 2025-01-09 16:27:32:

Test File Smart Description
Mimecast/mimecast-email-security/tests/test_attachment_protect.json {"processingId": "processingId", "aggregateId": "aggregateId", "sha1": "816b013c8be6e5708690645964b5d442c085041e", "accountId": "C0A0", "fileName": "tpsreport.docx", "sha256": "efe51c2453821310c7a34dca3054021d0f6d453b7133c381d75e3140901efd12", "fileExtension": "xlsm", "subType": null, "eventType": "attachment protect", "timestamp": 1689692409135, "md5": "4dbe9dbfb53438d9ce410535355cd973"}
Mimecast/mimecast-email-security/tests/test_av_logs.json AV detected bad.virus.found in file NULL from auser@mimecast.com
Mimecast/mimecast-email-security/tests/test_delivery.json Inbound email from john.doe@example.org to jane.doe@example.com
Mimecast/mimecast-email-security/tests/test_impersonation_protect.json Hold email from auser@mimecast.com
Mimecast/mimecast-email-security/tests/test_internal_email_project.json Restricted File Type - Found executable extension: dll on email from john.doe@example.org
Mimecast/mimecast-email-security/tests/test_journal.json Inbound email from newsletter@stub.com to neo@gmail.fr
Mimecast/mimecast-email-security/tests/test_process.json Hld email from john.doe015@gmail.com
Mimecast/mimecast-email-security/tests/test_process_with_attachment.json Allow email from auser@mimecast.com
Mimecast/mimecast-email-security/tests/test_process_with_multiple_attachments.json Acc email from johndoe@gmail.com
Mimecast/mimecast-email-security/tests/test_receipt.json Acc Inbound email from john.doe@gmail.com to admin@mcfr2.pro
Mimecast/mimecast-email-security/tests/test_receipt_urls.json Rej Inbound email from john.doe@gmail.com to admin@mcfr.pro
Mimecast/mimecast-email-security/tests/test_spam.json Spam detected in email from john.doe@example.org to jane.doe@example.com
Mimecast/mimecast-email-security/tests/test_url_protect_blocked.json Protected john@mcfr2.pro by Block URL http://www.mimcast.com

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements

@squioc squioc merged commit 21b43f2 into main Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants