-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update palo alto url.original #1422
base: main
Are you sure you want to change the base?
Conversation
Hello @squioc, j'ai mis à jour le parser dis moi si c'est mieux :) |
@@ -799,16 +799,8 @@ stages: | |||
url.original: "{{parsed_event.message.URL}}" | |||
|
|||
- set: | |||
url.original: "{{parsed_event.message.FileName or parsed_event.message.URLFilename}}" | |||
url.domain: '{{final.url.original.split("/")[0].split(":")[0]}}' | |||
url.original: "https://{{parsed_event.message.FileName or parsed_event.message.URLFilename}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a filter that check if Filename or URL Filename is set?
It will avoid tests with https
as destination.domain
and https://
as url.original
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try with filter None and filter null, I don't know the correct one ?
We should always parse url in url.original, the consistency is better for client search and automation. (PS I don't know the source of the registered domain field and top level domain field)