Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: trend micro vision email (341) #1428

Merged
merged 14 commits into from
Jan 21, 2025
Merged

Feature: trend micro vision email (341) #1428

merged 14 commits into from
Jan 21, 2025

Conversation

vg-svitla
Copy link
Contributor

Closes 341

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

Smart descriptions generated from the latest tests at 2025-01-21 17:28:10:

Test File Smart Description
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_1.json Observed TA0002 tactic(s) and T1560.002 technique(s) on 150.183.13.135, 433e:5c7b:50b0:d145:2c61:9d1d:f317:627e
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_2.json Observed TA0007 tactic(s) and T1082 technique(s) on 1802:d896:65fe:b84:742d:615:f69b:6600, 239.144.71.57
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_3.json Observed TA0005, TA0009 tactic(s) and T1005, T1070(T1070.006) technique(s) on 1802:d896:65fe:b84:742d:615:f69b:6600, 193.103.164.106
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_4.json Email with subject XXXXXXXXXXX. sent from XXXXXX@test.com
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_5.json Email with subject RE: PVI sent from XXXXX@test.com to XXXX@test.com, XXXXX@test.com
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_6.json Email with subject MySubject sent from XXXXX@test.com to XXX@test.com, XXXXt@test.com

@vg-svitla vg-svitla requested a review from squioc January 10, 2025 07:25
TOUFIKIzakarya
TOUFIKIzakarya reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@TOUFIKIzakarya TOUFIKIzakarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work.
Here are a few remarks.

Trend Micro/trend-micro-vision-one-oat/_meta/fields.yml Outdated Show resolved Hide resolved
Trend Micro/trend-micro-vision-one-oat/ingest/parser.yml Outdated Show resolved Hide resolved
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_6.json Outdated Show resolved Hide resolved
squioc
squioc requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work.
Some little changes to apply

Trend Micro/trend-micro-vision-one-oat/ingest/parser.yml Outdated Show resolved Hide resolved
Trend Micro/trend-micro-vision-one-oat/_meta/fields.yml Outdated Show resolved Hide resolved
TOUFIKIzakarya
TOUFIKIzakarya previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@TOUFIKIzakarya TOUFIKIzakarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

squioc
squioc requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement.
I detected some missing fields.

Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_4.json Outdated Show resolved Hide resolved
Trend Micro/trend-micro-vision-one-oat/tests/test_observed_attack_technique_5.json Outdated Show resolved Hide resolved
@vg-svitla vg-svitla requested a review from squioc January 21, 2025 15:15
@squioc squioc requested a review from TOUFIKIzakarya January 21, 2025 16:56
TOUFIKIzakarya
TOUFIKIzakarya previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@TOUFIKIzakarya TOUFIKIzakarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@squioc squioc force-pushed the feature/trend_micro_vision_email branch from 4f8044a to 19a5ab9 Compare January 21, 2025 17:26
squioc
squioc approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work

@squioc squioc merged commit ba58573 into main Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squioc squioc squioc approved these changes

@TOUFIKIzakarya TOUFIKIzakarya TOUFIKIzakarya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vg-svitla @squioc @TOUFIKIzakarya