This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #103 +/- ##
=================================================
+ Coverage 91.16% 91.69% +0.53%
- Complexity 114 115 +1
=================================================
Files 21 21
Lines 249 253 +4
Branches 16 17 +1
=================================================
+ Hits 227 232 +5
Misses 13 13
+ Partials 9 8 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Nyxes5
approved these changes
Mar 19, 2022
lars-vc
reviewed
Mar 20, 2022
backend/src/main/kotlin/be/osoc/team1/backend/services/StudentService.kt
Outdated
Show resolved
Hide resolved
Will the coach entity get deleted after the merge? I am afraid it will keep existing so maybe you can also delete it on your branch |
I merged the dev branch into this one, so the Coach entity is gone now. |
lars-vc
approved these changes
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91