Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Check if coach actually exists #103

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Check if coach actually exists #103

merged 6 commits into from
Mar 21, 2022

Conversation

TomAlard
Copy link
Contributor

Closes #91

@TomAlard TomAlard added this to the Milestone 1 milestone Mar 19, 2022
@TomAlard TomAlard requested review from Nyxes5 and lars-vc March 19, 2022 15:48
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #103 (0b68234) into development (f56be2f) will increase coverage by 0.53%.
The diff coverage is 71.42%.

@@                Coverage Diff                @@
##             development     #103      +/-   ##
=================================================
+ Coverage          91.16%   91.69%   +0.53%     
- Complexity           114      115       +1     
=================================================
  Files                 21       21              
  Lines                249      253       +4     
  Branches              16       17       +1     
=================================================
+ Hits                 227      232       +5     
  Misses                13       13              
+ Partials               9        8       -1     
Flag Coverage Δ
all_tests 91.69% <71.42%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/be/osoc/team1/backend/services/StudentService.kt 91.89% <71.42%> (+0.98%) ⬆️
...main/kotlin/be/osoc/team1/backend/entities/User.kt 100.00% <0.00%> (+8.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lars-vc
Copy link
Contributor

lars-vc commented Mar 20, 2022

Will the coach entity get deleted after the merge? I am afraid it will keep existing so maybe you can also delete it on your branch

@TomAlard
Copy link
Contributor Author

Will the coach entity get deleted after the merge? I am afraid it will keep existing so maybe you can also delete it on your branch

I merged the dev branch into this one, so the Coach entity is gone now.

@TomAlard TomAlard requested a review from lars-vc March 20, 2022 11:18
@TomAlard TomAlard merged commit 67dcc58 into development Mar 21, 2022
@TomAlard TomAlard deleted the check-coach-exists branch March 21, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if coach actually exists
3 participants