Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add endpoint to get all skills #232

Merged
merged 7 commits into from
Apr 22, 2022
Merged

Conversation

MaartenS11
Copy link
Contributor

@MaartenS11 MaartenS11 commented Apr 17, 2022

New skills endpoint is at /skills this will return all skills present in the database.

Closes #218.

New feature checklist:

  • I've added tests for the new feature (100% coverage)
  • I've updated the osoc.yaml file

Also changed line endings of BaseController.kt, BaseService.kt and CommunicationService.kt to be LF instead of CRLF.
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #232 (4f59f3e) into development (0c27fcb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             development     #232      +/-   ##
=================================================
+ Coverage          95.47%   95.50%   +0.03%     
- Complexity           224      225       +1     
=================================================
  Files                 44       44              
  Lines                574      579       +5     
  Branches              42       42              
=================================================
+ Hits                 548      553       +5     
  Misses                16       16              
  Partials              10       10              
Flag Coverage Δ
all_tests 95.50% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/osoc/team1/backend/controllers/BaseController.kt 100.00% <100.00%> (ø)
...am1/backend/controllers/CommunicationController.kt 100.00% <100.00%> (ø)
...tlin/be/osoc/team1/backend/services/BaseService.kt 100.00% <100.00%> (ø)
...soc/team1/backend/services/CommunicationService.kt 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MaartenS11 MaartenS11 marked this pull request as draft April 17, 2022 20:26
@MaartenS11 MaartenS11 marked this pull request as ready for review April 22, 2022 13:19
Nyxes5
Nyxes5 previously requested changes Apr 22, 2022
Copy link
Contributor

@Nyxes5 Nyxes5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a service test pls?

@TomAlard TomAlard requested a review from Nyxes5 April 22, 2022 13:53
@lars-vc lars-vc added this to the Milestone 2 milestone Apr 22, 2022
@MaartenS11 MaartenS11 merged commit d9b5e2d into development Apr 22, 2022
@MaartenS11 MaartenS11 deleted the get-all-skills-endpoint branch April 22, 2022 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getAllSkills endpoint
4 participants