Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Handle other skill option #258

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Handle other skill option #258

merged 4 commits into from
Apr 26, 2022

Conversation

MaartenS11
Copy link
Contributor

@MaartenS11 MaartenS11 commented Apr 24, 2022

This pr adds correct handling for the other skill option in the tally form. Previously a student selecting "Other" would get Skill("Other"). With this pr the tally form deserializer will look at the correct field on the tally form to get the name of that other skill and add that skill into the skill list.

Checklist:

  • I've updated the existing tests to test this behavior

@MaartenS11 MaartenS11 added the enhancement New feature or request label Apr 24, 2022
@MaartenS11 MaartenS11 self-assigned this Apr 24, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #258 (6d9c855) into development (c1d7d04) will decrease coverage by 0.14%.
The diff coverage is 87.50%.

@@                Coverage Diff                @@
##             development     #258      +/-   ##
=================================================
- Coverage          95.84%   95.70%   -0.15%     
  Complexity           229      229              
=================================================
  Files                 44       44              
  Lines                602      605       +3     
  Branches              43       44       +1     
=================================================
+ Hits                 577      579       +2     
  Misses                15       15              
- Partials              10       11       +1     
Flag Coverage Δ
all_tests 95.70% <87.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/kotlin/be/osoc/team1/backend/entities/Student.kt 95.23% <ø> (ø)
...in/be/osoc/team1/backend/util/TallyDeserializer.kt 96.07% <87.50%> (-1.84%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MaartenS11 MaartenS11 requested a review from lars-vc April 25, 2022 13:29
@lars-vc lars-vc merged commit aa8dd85 into development Apr 26, 2022
@lars-vc lars-vc deleted the tally-other-skill branch April 26, 2022 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants