Skip to content

Commit

Permalink
libsemanage: Fix null pointer dereference in semanage_module_key_destroy
Browse files Browse the repository at this point in the history
If modkey is NULL, semanage_module_key_destroy() would still try to
initialize a modkey after freeing it.

Signed-off-by: Yuli Khodorkovskiy <ykhodorkovskiy@tresys.com>
Signed-off-by: James Carter <jwcart2@tycho.nsa.gov>
  • Loading branch information
gitstashpop authored and jwcart2 committed Aug 6, 2015
1 parent 228261a commit d4f3ba7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions libsemanage/src/modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -690,10 +690,12 @@ int semanage_module_key_destroy(semanage_handle_t *sh,
{
assert(sh);

if (modkey) {
free(modkey->name);
if (!modkey) {
return 0;
}

free(modkey->name);

return semanage_module_key_init(sh, modkey);
}

Expand Down

0 comments on commit d4f3ba7

Please sign in to comment.