Fix catalogue tracking (maint-3.8 branch) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function that fails when using catalogue tracking is ac.get_source_ra_dec(). This function seems to be broken since the port of ata_control to the REST API. However, this function is only used here to check if the source is up, so we can disable it and assume that the source is up. I have tested that this commit fixes catalogue tracking for the trackscan and on-off modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function that fails when using catalogue tracking is
ac.get_source_ra_dec(). This function seems to be broken since theport of ata_control to the REST API. However, this function is only used here to check if the source is up, so we can disable it
and assume that the source is up.
I have tested that this commit fixes catalogue tracking for the trackscan and on-off modes.
This PR is intended as a quick fix to #11.