adding filter on sobjects to mitigate issue with VF limit

[seanpat09]

Critical Changes

Mitigates bug in #1223 by filtering out EntityDefinitions where the following are false:
IsCustomizable
IsApexTriggerable
IsCustomSetting

Changes

Issues Closed

#1223

[Szandor72]

Can we please doublecheck the early return doesn't make the additional filtering obsolete? It looks to me that way

Can we also check the use of global describe - if we filter the results at one place, how about the others where the DescribeResult is used?

I cannot estimate if the additional check would prevent specific (rare) standard objects from being used by DLRS. I trust you on that :)

[seanpat09]

The initial early return is to check if there are still too many sObjects even after doing the check in the EntityDefinition table. I was trying to change as a little as possible so I didn't want to remove the reference to sobjectDescription, which is caching Schema.getGlobalDescribe(). filtering in the for loops is done because we're still iterating over sObjectDescription. Also those for loops do some other stuff with the describe information that I wasn't sure was available from the EntityDefinition table.

As for the other uses of the DescribeResult, I believe we should be fine because we're not looping over all the results, but just using the a single value in the map retrieved by whatever the user had selected.

I am not sure if there are any standard objects that are blocked by these changes either, but it looks like like the regular standard objects are there.

[sfenton3]

Testing: Some objects have inordinately large number of child records. User object has the same number of child records as parent records. Something to keep note of when we make more changes to the new wizard.

Security feedback:
I previously received feedback to put hardcoded SOQL into a selector. If not, we should have With Security Enforced because this is periodically reviewed for security concerns on the app exchange, and may raise a flag.

List<EntityDefinition> entityDefinitions = [ SELECT QualifiedApiName FROM EntityDefinition WHERE IsCustomSetting = FALSE AND IsCustomizable = TRUE AND isApexTriggerable = TRUE ];