Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CI pipeline #201

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Expand CI pipeline #201

merged 4 commits into from
Jul 8, 2023

Conversation

ChrisThrasher
Copy link
Member

@ChrisThrasher ChrisThrasher commented Jul 8, 2023

This PR started off adding new compilers. Eventually I added static builds (instead of only shared builds) and quickly discovered there were some issues with incorrect dllimport/dllexport statements. I found out that CSFML lacked the same CSFML_STATIC definition that SFML has for supported static library builds so I ported that over from SFML in an identical fashion and now the new and improved CI pipeline is happy.

EDIT: I removed the static library bits so this PR is now only about adding CI jobs

@eXpl0it3r
Copy link
Member

eXpl0it3r commented Jul 8, 2023

The reason we haven't supported static linking with CSFML is, that it stops being a C-library when you link it statically, as the C linker wouldn't know what to do with these C++ symbols. Not exactly sure if allowing to link CSFML statically as C++ library is really useful in any way, as you then could just directly use SFML to begin with... 🤔

@ChrisThrasher
Copy link
Member Author

If static builds aren't reasonable then let's hardcode the use of shared libraries into CSFML itself. We can use the SHARED argument to add_library to make sure only shared libs get built and totally ignore the value of BUILD_SHARED_LIBS.

For now I'll remove the static lib stuff from this PR so it's only about new CI jobs.

@ChrisThrasher ChrisThrasher changed the title Fix static library build and expand CI pipeline Expand CI pipeline Jul 8, 2023
@ChrisThrasher ChrisThrasher merged commit a3657e1 into master Jul 8, 2023
@ChrisThrasher ChrisThrasher deleted the ci branch July 8, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants