Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sfFont_hasGlyph #230

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Added sfFont_hasGlyph #230

merged 1 commit into from
Feb 19, 2024

Conversation

texus
Copy link
Contributor

@texus texus commented Feb 18, 2024

This implements sf::Font::hasGlyph which was added in SFML 2.6.0 (SFML/SFML@4318745)

ChrisThrasher
ChrisThrasher reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@ChrisThrasher ChrisThrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this! It was my job to find all these API additions so my bad for missing it. Once you fix a small documentation comment I can merge this.

include/SFML/Graphics/Font.h Show resolved Hide resolved
@eXpl0it3r eXpl0it3r merged commit 0f4b9a4 into SFML:2.6.x Feb 19, 2024
18 checks passed
@eXpl0it3r
Copy link
Member

Thanks for spotting and adding this!

mgrojo added a commit to mgrojo/ASFML that referenced this pull request May 20, 2024
@mgrojo
Updated to CSFML 2.6.1
5a96742 
Implemented changes:
SFML/CSFML#230
SFML/CSFML@e0589c3
@eXpl0it3r eXpl0it3r added this to the 2.6.1 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisThrasher ChrisThrasher ChrisThrasher left review comments

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@texus @eXpl0it3r @ChrisThrasher