-
Notifications
You must be signed in to change notification settings - Fork 186
New Github Actions (fix #199) #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, as expected the Windows MinGW workflow needs a re-run. |
|
Thanks a lot for this PR! I have some concerns about the number of builds that you have here... I think that x86/Win32 build should be dropped - this will already cut a lot computation. It's very rarely used these days... As for Ubuntu... I'd leave gcc-9 and clang-10 only - I really doubt that there will be any differences there because we're not using a lot of fancy C++14/17 etc. code. As for MacOS... I'm not really sure how quickly XCode evolves? I think we should use 13.2, because that's the version that SFML's CI uses and MacOS seems to be moving forward quickly, so SFML's MacOS implementation is not guaranteed to work on older versions. |
|
Thanks a lot! Merged |
|
Great, thanks to you for all the work on this project. |
|
For some reason if fails in master now. Any ideas why it’s happening? |
|
Sorry I missed the notification, this is the issue I mentioned in the "Note" of the first message, you need to re-run the workflow. |
|
Yes, just put them all into one file -- which is how I'd do it anyway in the first place. These really aren't different workflows, it's the same workflow on several systems. |

New GitHub Actions, like last time in #132 it is heavily inspired by my dynamic_bitset Github Actions.
Fix #199
Local actions
The new workflows are better organized using "local" actions:
Setup ccachein .github/actions/setup_ccacheSetup CMakein .github/actions/setup_cmake/action.ymlInstall SFMLin .github/actions/install_sfml/action.ymlNew workflows
The workflow are now separated depending on the build environment:
(ubuntu-18.04 disabled because SFML seems to have dependencies problems with it)
(currently mingw-w64-x86_64-gcc-11.2.0-10 and mingw-w64-x86_64-clang-13.0.1-3)
(using the default toolsets as SFML doesn't compile using ClangCL on the 2.5.1 tag but the issue is fixed on branch 2.6.x)
(I only kept the majors versions of Xcode otherwise the workflow the veeeeeery long)
I also created a workflow dedicated to clang-format:
(as it was already used before)
Badges
I added the badges to the README, at the moment it might look like this:

But when the workflow will be run on master it will look like this:

C++11
The old Github Action where invoking CMake with
-D CMAKE_CXX_STANDARD=11as some old compilers still use C++98 as default standard and the project was requiring C++03.But according to #7 C++11 is now the minimum required standard so I made it a requirement on the ImGui-SFML target in the CMakeLists.txt
Note
The Windows MinGW workflow might need to be re-run the first time to let the gcc jobs bootstrap the SFML installation cache as the CMake configuration of SFML fails when using MinGW with clang stating that it doesn't find OpenAL, quite strange but we are here to build imgui-sfml, not SFML, so until it is fixed I think using the gcc built version from the cache is good enough.
To re-run the jobs:
