Replaced deprecated sf::Keyboard::Return with sf::Keyboard::Enter #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
approved these changes
Apr 23, 2022
Contributor
|
Thank you, merged. |
Contributor
Author
Glad to have given even a small change to a repo that has helped me many times in projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on a project using the latest snapshot of SFML master branch (where the SFML v3 commits are going) I noticed that the
sf::Keyboard::Returnwas no longer marked deprecated but had now been removed which causedimgui-sfml.cppto fail to compile since it still relied on this enum entry. Replaced the entry with the preferredsf::Keyboard::Enter