Reenable compiler warnings #251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bambo-Borris
approved these changes
Aug 8, 2023
Contributor
Bambo-Borris
left a comment
Bambo-Borris
left a comment
There was a problem hiding this comment.
I'm shocked that these were removed. As an imgui-sfml power user, I would feel better knowing they're enabled.
ChrisThrasher
force-pushed
the
compiler_warnings
branch
from
e98ee3f to
2b915ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #248. Compiler warnings a critical part of quickly writing safe and correct code. It's imperative we use this. This PR adds compiler warnings that are disabled by default and only enforced as hard errors in CI. This way it does not pose a risk of 3rd parties failing to build our code due to
/WXor-Werrorturning a warning into an error.