Skip to content

Conversation

@AlexAUT
Copy link
Contributor

@AlexAUT AlexAUT commented Jul 20, 2024

Event inheritance was removed in SFML3. I can also split the lambda into two if that is preferred over the auto parameter.

@AlexAUT AlexAUT changed the title Fixs for removed Event Inheritance Fix for removed Event Inheritance Jul 20, 2024
@ChrisThrasher
Copy link
Member

ChrisThrasher commented Jul 21, 2024

Looks like we need to update the examples to handle how pollEvent now returns a std::optional<sf::Event> rather than just an sf::Event. Would you mind fixing that real quick?

@AlexAUT
Copy link
Contributor Author

AlexAUT commented Jul 21, 2024

You can also close #285 after this one is merged.

@ChrisThrasher
Copy link
Member

You can also close #285 after this one is merged.

lol I forgot to merge my own PR. My bad.

@ChrisThrasher ChrisThrasher merged commit 4bebb4e into SFML:master Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants