Skip to content

Conversation

@ChrisThrasher
Copy link
Member

No description provided.

@ChrisThrasher
Copy link
Member Author

ChrisThrasher commented Dec 6, 2024

@Legulysse I decided I want to add two version of ImGui to CI, doubling the job count. That should be fine since our CI pipeline isn't excessively slow to begin with. Is this our best strategy? Test with the minimum version w/o deprecated interfaces and the latest version w/ deprecated interfaces?

@Legulysse
Copy link
Contributor

@ChrisThrasher It seems like a really good idea to check both the latest supported version, and the minimum supported version !

Since imgui is maintained in a way that provides as much backwards-compatibility as possible, having the minimum version tested with the deprecation flag could be seen as unneeded, but I believe it's a good incentive to help moving the code forward, as long as it does not put excessive work on maintaining the latest supported version 🤔

@ChrisThrasher ChrisThrasher merged commit bf46eaa into 2.6.x Dec 7, 2024
98 checks passed
@ChrisThrasher ChrisThrasher deleted the imgui_version branch December 7, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants