Skip reassignment of base value in Object::calculate_value
#119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For values that are assigned in parent members, the current value is calculated dynamically by traversing the linear history of the member and applying each change to the returned value. An example where this happens can be seen here:
When retrieving
Third.member
,Object::calculate_value
searches for the base member that uses the assignment operator (in this caseFirst.member
) and then applies all operations in linear order (= 0
,+ 5
,+ 3
) to arrive at the final value8
.Since
Object::calculate_value
copies the initial return value from the base member, reapplying the assignment operation is superflous as it doesn't change the value. The reassignment can also create problems as seen in #118 becauseNone
doesn't allow reassignments. Therefore, the initial reassignment is now removed.