Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance output summary of converter run for debugging #1343

Closed
2 tasks
heinezen opened this issue Dec 18, 2020 · 4 comments · Fixed by #1591
Closed
2 tasks

Enhance output summary of converter run for debugging #1343

heinezen opened this issue Dec 18, 2020 · 4 comments · Fixed by #1591
Labels
area: assets Involved with assets (images, sounds, ...) good first issue Suitable for newcomers improvement Enhancement of an existing component lang: python Done in Python code

Comments

@heinezen
Copy link
Member

heinezen commented Dec 18, 2020

Required skills: Python

Difficulty: Easy

During a converter run, a bunch of intermediary objects are created in the processor stage, specifically AoE-like and API-like objects. These are used in the transformation from Genie Engine formats to openage formats (e.g. nyan).

The content and helper functions of the intermediary objects are used to map properties of the objects in the original game to properties in the openage API (e.g. a unit's ability). The motivation for having debug output for these objects is that this will help us detect semantic errors in the converter implementation. Because of the high number of objects in the game data, checking this during a live debug is very hard to do.

Debug output of a run contains a plaintext dump of the most relevant content and output of helper functions. We store it in a dedicated directory (assets/converted/debug) and distinguish between the runs by using timestamps for folder names. The debug output is separated by conversion stage (init, read, processor, export). A lot of stuff is already implemented (see here), but improving it can't hurt can it?

  • Log the sound files that were requested for export but not found in the export stage here
  • Execution time for each stage (read, conversion, export)

Further reading:

@heinezen heinezen added improvement Enhancement of an existing component lang: python Done in Python code area: assets Involved with assets (images, sounds, ...) labels Dec 18, 2020
@heinezen heinezen self-assigned this Dec 18, 2020
@heinezen heinezen added good first issue Suitable for newcomers and removed good first issue Suitable for newcomers labels Dec 18, 2020
@heinezen heinezen changed the title Output summary of converter run for debugging Enhance output summary of converter run for debugging Dec 31, 2020
@heinezen heinezen assigned heinezen and unassigned heinezen Jan 3, 2021
@heinezen heinezen linked a pull request Jan 19, 2021 that will close this issue
3 tasks
@heinezen heinezen removed a link to a pull request Jan 19, 2021
3 tasks
@heinezen heinezen added the good first issue Suitable for newcomers label Jan 19, 2021
@heinezen heinezen removed their assignment Jan 21, 2021
@fabiobarkoski
Copy link
Contributor

Some PRs related to this issue were merged. If remain some work to do, can I try to work on this?

@heinezen
Copy link
Member Author

heinezen commented Sep 13, 2023

@fabiobarkoski Totally. I've updated the issue with a few ideas.

@fabiobarkoski
Copy link
Contributor

Thanks. If in some point I need help, is better ask here or on the matrix chat?

@heinezen
Copy link
Member Author

@fabiobarkoski Both is fine. The chat is better for back and forth if you have technical issues but whatever you're more comfortable with usually works best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: assets Involved with assets (images, sounds, ...) good first issue Suitable for newcomers improvement Enhancement of an existing component lang: python Done in Python code
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants