Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Birthday] Cog model restructure #660

Open
wants to merge 1 commit into
base: V3/testing
Choose a base branch
from
Open

[Birthday] Cog model restructure #660

wants to merge 1 commit into from

Commits on Dec 11, 2023

  1. [Birthday] Cog model restructure 

    Restructure cog `Birthday` according to SFUAnime#608. No
functional changes expected.

Command handlers that utilize the `MonthDayConverter` now perform a
"typing cast" to inform static type checkers that the birthday being
passed to the command handlers as `MonthDayConverter` will be
subsequently passed to the corresponding methods in `CommandsCore` as
type `datetime.datetime` instead of `MonthDayConverter`. Note that
Python typing cast does not change or restrict any functionalities
because it is only information to static type checkers.

`MonthDayConverter` now exposes the `InputType` and `OutputType` as type
aliases so that code utilizes the converted can be type-hinted better.

The birth year constant 2020 is moved to `constants.py` as
`DEFAULT_YEAR`.
    @quachtridat
    quachtridat committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    137ac58 View commit details
    Browse the repository at this point in the history