[WordFilter] Try compiling RegEx before adding #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves SFUAnime#646 by compiling RegEx before adding a RegEx string into WordFilter's books. With this commit, at word filter insertion time (`[p]wordfilter regex add <word>`), `re.compile` will be invoked, and if there is a `re.error`, a message will be sent to where the command has been invoked to notify the user executing the command about the invalid RegEx pattern that was input. Without this commit, the cog will crash when it tries to substitute/match/search invalid RegEx patterns during handling of an `on_message` event. See SFUAnime#646 for an example traceback.
Merge branch `V3/testing` into `quachtridat/issue646-wordfilter-cog-validate-regex`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #646 by compiling RegEx before adding a RegEx string into WordFilter's books.
Details
With this commit, at word filter insertion time (
[p]wordfilter regex add <word>),re.compilewill be invoked, and if there is are.error, a message will be sent to where the command has been invoked to notify the user executing the command about the invalid RegEx pattern that was input.Without this commit, the cog will crash when it tries to substitute/match/search invalid RegEx patterns during handling of an
on_messageevent. See #646 for an example traceback.