Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ray[default] with ray[tune] #112

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Replace ray[default] with ray[tune] #112

merged 5 commits into from
Dec 20, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Dec 20, 2022

Motivation

To install dependencies for Ray Tune, we need to use pip install -U 'ray[tune]' script instead of pip install 'ray[default]' script.
Refer to this docs and this code for details.

TODO

  • Test tools/tune.py script

Modification

Please briefly describe what modification is made in this PR.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@76523e5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage        ?   72.79%           
=======================================
  Files           ?       59           
  Lines           ?     1632           
  Branches        ?      235           
=======================================
  Hits            ?     1188           
  Misses          ?      345           
  Partials        ?       99           
Flag Coverage Δ
unittests 72.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKIEEK KKIEEK changed the title Replace ray[default] with ray[tune] Replace \ray[default]\ with ray[tune] Dec 20, 2022
@KKIEEK KKIEEK changed the title Replace \ray[default]\ with ray[tune] Replace ray[default] with ray[tune] Dec 20, 2022
@KKIEEK KKIEEK requested review from yhna940 and nijkah and removed request for yhna940 December 20, 2022 04:56
@KKIEEK KKIEEK merged commit d0fbcce into main Dec 20, 2022
@KKIEEK KKIEEK deleted the deps/ray-tune branch December 20, 2022 06:21
@yhna940 yhna940 mentioned this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants