Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix duplicate register for searchers #116

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

nijkah
Copy link
Member

@nijkah nijkah commented Dec 20, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When flaml is not installed, it should be called to filter duplicated classes since SEARCH_ALG_IMPORT are function,

Check these

Modification

Please briefly describe what modification is made in this PR.

@nijkah nijkah requested review from KKIEEK and yhna940 December 20, 2022 06:40
@nijkah nijkah marked this pull request as ready for review December 20, 2022 06:40
@nijkah nijkah changed the title [Fix] Duplicate register for searchers [Fix] Fix duplicate register for searchers Dec 20, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@85e7ce2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage        ?   72.81%           
=======================================
  Files           ?       59           
  Lines           ?     1633           
  Branches        ?      236           
=======================================
  Hits            ?     1189           
  Misses          ?      345           
  Partials        ?       99           
Flag Coverage Δ
unittests 72.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Junhwa Song <ethan9867@gmail.com>
Signed-off-by: Hakjin Lee <nijkah@gmail.com>
@KKIEEK KKIEEK merged commit 796e6da into SIAnalytics:main Dec 20, 2022
@nijkah nijkah deleted the fix/duplicate_register branch December 20, 2022 07:21
@yhna940 yhna940 mentioned this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants