Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ray from v2.1.0 to v2.2.0 #121

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Bump ray from v2.1.0 to v2.2.0 #121

merged 3 commits into from
Dec 21, 2022

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Dec 21, 2022

Motivation

We need to bump ray to v2.2.0 to support the relative path.
Please refer to this issue and this PR for details.

TODO

  • Test

@nijkah nijkah linked an issue Dec 21, 2022 that may be closed by this pull request
Copy link
Member

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@12b09c8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage        ?   72.79%           
=======================================
  Files           ?       59           
  Lines           ?     1632           
  Branches        ?      235           
=======================================
  Hits            ?     1188           
  Misses          ?      345           
  Partials        ?       99           
Flag Coverage Δ
unittests 72.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKIEEK
Copy link
Contributor Author

KKIEEK commented Dec 21, 2022

@nijkah
Unfortunately, chdir_to_trial_dir is not working in Trainer class. reference

@KKIEEK
Copy link
Contributor Author

KKIEEK commented Dec 21, 2022

Probably this line seems to be the problem.

@KKIEEK KKIEEK merged commit 9475dc2 into main Dec 21, 2022
@KKIEEK KKIEEK deleted the bump/ray-2.2.0 branch December 21, 2022 13:48
@yhna940 yhna940 mentioned this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants