Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] mlflow attr #135

Merged
merged 1 commit into from
Jan 10, 2023
Merged

[Fix] mlflow attr #135

merged 1 commit into from
Jan 10, 2023

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Jan 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

This PR is written to update the attributes used in the mlflow callback class due to the update of the Ray framework to a new version.

Modification

  • Updated the self.client and self.experiment_id attributes.
  • Changed self.save_artifact to self.should_save_artifact.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
    image
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@yhna940 yhna940 added the bug Something isn't working label Jan 10, 2023
@yhna940 yhna940 requested review from nijkah and KKIEEK January 10, 2023 02:00
@yhna940 yhna940 self-assigned this Jan 10, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@098cb73). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage        ?   61.65%           
=======================================
  Files           ?       63           
  Lines           ?     1961           
  Branches        ?      312           
=======================================
  Hits            ?     1209           
  Misses          ?      648           
  Partials        ?      104           
Flag Coverage Δ
unittests 61.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@KKIEEK KKIEEK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhna940 yhna940 merged commit 7bc1b70 into main Jan 10, 2023
@yhna940 yhna940 deleted the hotfix/mlflow-logger branch January 10, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants