Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use args.exp_name #139

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Don't use args.exp_name #139

merged 1 commit into from
Jan 18, 2023

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Jan 17, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Related to #136

Modification

Please briefly describe what modification is made in this PR.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@KKIEEK KKIEEK requested review from nijkah and yhna940 January 17, 2023 16:39
Copy link
Contributor

@yhna940 yhna940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KKIEEK KKIEEK merged commit 528eacc into main Jan 18, 2023
@KKIEEK KKIEEK deleted the fix/exp-name branch January 18, 2023 01:06
@KKIEEK KKIEEK linked an issue Jan 18, 2023 that may be closed by this pull request
@KKIEEK KKIEEK mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Handling cli input experiment names
2 participants