Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Unit Test #25

Merged
merged 13 commits into from
May 27, 2022
Merged

[Enhancement] Unit Test #25

merged 13 commits into from
May 27, 2022

Conversation

nijkah
Copy link
Member

@nijkah nijkah commented May 24, 2022

We add unit tests for the code.
Closes #25

@nijkah nijkah requested review from yhna940 and KKIEEK May 24, 2022 06:43
@nijkah nijkah marked this pull request as ready for review May 24, 2022 07:07
@KKIEEK
Copy link
Contributor

KKIEEK commented May 25, 2022

저는 전반적으로 코드 퀄리티에 만족합니다.

@github-actions
Copy link

Coverage report

The coverage rate is 83.46000000000001%

The branch rate is 62.029999999999994%

100% of new lines are covered.

Diff Coverage details (click to unfold)

mmtune/mm/context/rewriters/decouple.py

100.0% of new lines are covered

mmtune/mm/context/rewriters/builder.py

100.0% of new lines are covered

mmtune/ray/stoppers/early_drop.py

100.0% of new lines are covered

@nijkah nijkah linked an issue May 26, 2022 that may be closed by this pull request
Copy link
Contributor

@yhna940 yhna940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nijkah nijkah merged commit ad52fe5 into master May 27, 2022
@nijkah nijkah deleted the feature/unit_test branch May 27, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Test Code
3 participants