-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Trust-region algorithm searcher #33
Conversation
b9a3acd
to
2a38afe
Compare
We chose this algorithm because it showed the best performance in bbo benchmark experiments. [Ref] |
Coverage reportThe coverage rate is The branch rate is
Diff Coverage details (click to unfold)mmtune/ray/searchers/init.py
mmtune/mm/tasks/disc_test_func.py
mmtune/mm/tasks/init.py
mmtune/mm/tasks/cont_test_func.py
mmtune/ray/searchers/trust_region.py
|
mmtune/mm/tasks/cont_test_func.py
Outdated
return _styblinksitang(x, 100) | ||
|
||
def run(self, *args, **kwargs): | ||
args = kwargs['args'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using args = self.args
as in other tasks?
mmtune/mm/tasks/disc_test_func.py
Outdated
return o | ||
|
||
def run(self, *args, **kwargs): | ||
args = kwargs['args'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using args = self.args
as in other tasks?
space: Optional[Union[Dict]] = None, | ||
metric: Optional[str] = None, | ||
mode: Optional[str] = None, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring is required.
@yhna940 |
mmtune/mm/tasks/cont_test_func.py
Outdated
def sphere(x: np.ndarray) -> float: | ||
"""The most classical continuous optimization testbed. | ||
|
||
If you do not solve that one then you have a bug. | ||
""" | ||
assert x.ndim == 1 | ||
return float(x.dot(x)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the previous class Sphere
be deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the sphere function alone does not seem to be a sufficient optimization test, a new Test function including it has been added. I used the nevergrad benchmark (noise free version).
9e62f92
to
0e8e15c
Compare
0b9b559
to
9121ff2
Compare
No description provided.