Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor refactoring #42

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Fix minor refactoring #42

merged 2 commits into from
Jun 14, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Jun 14, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Coverage report

The coverage rate is 86.99%

The branch rate is 66.17%

91% of new lines are covered.

Diff Coverage details (click to unfold)

mmtune/mm/context/rewriters/register.py

100.0% of new lines are covered

mmtune/mm/context/rewriters/instantiate.py

100.0% of new lines are covered

mmtune/mm/context/rewriters/path.py

100.0% of new lines are covered

mmtune/mm/tasks/base.py

100.0% of new lines are covered

mmtune/mm/context/rewriters/dump.py

100.0% of new lines are covered

mmtune/mm/context/rewriters/merge.py

66.66666666666667% of new lines are covered

mmtune/mm/context/rewriters/init.py

100.0% of new lines are covered

@yhna940 yhna940 requested review from KKIEEK and nijkah June 14, 2022 02:32
@@ -9,18 +9,18 @@
class ConfigMerger(BaseRewriter):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think MergeConfig is better than ConfigMerger, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do it.

@yhna940 yhna940 requested a review from KKIEEK June 14, 2022 06:06
@yhna940 yhna940 merged commit c0246f7 into master Jun 14, 2022
@yhna940 yhna940 deleted the feature/refact-etc branch June 14, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants