Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load rewriter #43

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Add load rewriter #43

merged 4 commits into from
Jun 22, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Jun 22, 2022

This is for when the trial is restarted by the scheduler. In other cases, some results from previous training may be used selectively. e.g. pbt

@yhna940 yhna940 requested review from nijkah and KKIEEK June 22, 2022 01:51
@nijkah
Copy link
Member

nijkah commented Jun 22, 2022

For mmsegmentation case, an argument for load-from checkpoints already exists.
https://github.com/SIAnalytics/mmtune/blob/4d64042c66fbb418e9dc5218f7bc7aead2bc292c/mmtune/mm/tasks/mmseg.py#L35-L36

Is there any reason to support it as Rewriter?
See related discussions open-mmlab/mmdetection#8144 (comment), open-mmlab/mmdetection#8189

@nijkah
Copy link
Member

nijkah commented Jun 22, 2022

The parameter resume-from also exists. Can I ask you to explain the use case briefly?

@github-actions
Copy link

Coverage report

The coverage rate is 84.97%

The branch rate is 65.92%

80% of new lines are covered.

Diff Coverage details (click to unfold)

mmtune/mm/context/rewriters/init.py

100.0% of new lines are covered

mmtune/mm/context/rewriters/resume.py

100.0% of new lines are covered

mmtune/mm/hooks/checkpoint.py

55.55555555555556% of new lines are covered

@yhna940
Copy link
Contributor Author

yhna940 commented Jun 22, 2022

@nijkah
Copy link
Member

nijkah commented Jun 22, 2022

OK, I understand its purpose. But, there is still one thing left to worry about.
Is there any side effect possibility that some searches, which do not use checkpoint_dir, try to load the latest checkpoint?

@yhna940
Copy link
Contributor Author

yhna940 commented Jun 22, 2022

As far as I know there are no side effects. Search algorithm that does not use checkpoint_dir puts None in that place by default.

@yhna940 yhna940 merged commit c5dae95 into master Jun 22, 2022
@yhna940 yhna940 deleted the feature/checkpoint branch June 22, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants