Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint bug & Support PBT #53

Merged
merged 10 commits into from
Jun 29, 2022
Merged

Fix checkpoint bug & Support PBT #53

merged 10 commits into from
Jun 29, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Jun 29, 2022

No description provided.

yhna940 and others added 6 commits June 26, 2022 18:23
Signed-off-by: Younghwan Na <100389977+yhna940@users.noreply.github.com>
@yhna940 yhna940 requested review from KKIEEK and nijkah June 29, 2022 02:20
@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Coverage report

The coverage rate is 79.07%

The branch rate is 58.19%

50% of new lines are covered.

Diff Coverage details (click to unfold)

mmtune/ray/schedulers/init.py

100.0% of new lines are covered

mmtune/ray/schedulers/pbt.py

40.625% of new lines are covered

mmtune/mm/hooks/checkpoint.py

66.66666666666667% of new lines are covered

mmtune/mm/context/rewriters/resume.py

100.0% of new lines are covered

Copy link
Member

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
BTW please change the PR title as a readable comment.

@yhna940 yhna940 changed the title Test/checkpoint Fix checkpoint bug Jun 29, 2022
@nijkah nijkah changed the title Fix checkpoint bug Fix checkpoint bug & Support PBT Jun 29, 2022
@yhna940 yhna940 merged commit 1bd4d49 into master Jun 29, 2022
@nijkah nijkah deleted the test/checkpoint branch September 8, 2022 06:41
@nijkah nijkah mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] AttributeError: 'RayCheckpointHook' object has no attribute 'out_dir'
2 participants