[Refactor] Upgrade ray from 1.9.1 to 2.1.0 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junhwa Song <ethan9867@gmail.com>
added 2 commits
December 1, 2022 14:34
KKIEEK
force-pushed
the
ray/v2.1.0
branch
2 times, most recently
from
9648205
to
65de9b9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage ? 72.95%
=======================================
Files ? 61
Lines ? 1553
Branches ? 225
=======================================
Hits ? 1133
Misses ? 331
Partials ? 89
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nijkah
previously requested changes
Dec 15, 2022
nijkah
reviewed
Dec 15, 2022
Comment on lines
+69
to
+71
| failure_config=None, # todo | ||
| sync_config=None, # todo | ||
| checkpoint_config=None, # todo |
There was a problem hiding this comment.
Are these required to be edited in this PR? or just future works?
nijkah
reviewed
Dec 15, 2022
nijkah
reviewed
Dec 15, 2022
Co-authored-by: Hakjin Lee <nijkah@gmail.com> Signed-off-by: Junhwa Song <ethan9867@gmail.com>
nijkah
reviewed
Dec 15, 2022
Co-authored-by: Hakjin Lee <nijkah@gmail.com> Signed-off-by: Junhwa Song <ethan9867@gmail.com>
* Support custom trainer and backend * Add comment * Add assertion * Fix typo * Update siatune/ray/config.py * Apply lint * Fix test code Co-authored-by: Hakjin Lee <nijkah@gmail.com>
nijkah
reviewed
Dec 15, 2022
Co-authored-by: Hakjin Lee <nijkah@gmail.com> Signed-off-by: Junhwa Song <ethan9867@gmail.com>
* Update class signature * Update mmseg * Update mmdet * Update mmcls * Update configs * Fix test code
* Fix blocking issue at test_tasks.py * Support single GPU tuning * Bump FLAML to v1.0.14 to avoid deprecated warning
nijkah
dismissed
their stale review
The backend argument is determined by invoking the init_process_group function in run method.
KKIEEK
commented
Dec 16, 2022
Signed-off-by: Junhwa Song <ethan9867@gmail.com>
KKIEEK
commented
Dec 17, 2022
Signed-off-by: Junhwa Song <ethan9867@gmail.com>
Signed-off-by: Junhwa Song <ethan9867@gmail.com>
nijkah
approved these changes
Dec 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41
Sub PRs
Todo