Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always try to use PAT prior to GITHUB_TOKEN #105

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Always try to use PAT prior to GITHUB_TOKEN #105

merged 1 commit into from
Feb 7, 2023

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Feb 7, 2023

Fixes #104

For every single place where GITHUB_TOKEN is used, we should try to use the PAT secret first and then fallback to using GITHUB_TOKEN if PAT is not defined. This fallback is done by the || operator in GH Actions workflow logic.

@CasperWA CasperWA enabled auto-merge (squash) February 7, 2023 08:49
francescalb
francescalb approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@CasperWA CasperWA merged commit 31860cb into main Feb 7, 2023
@CasperWA CasperWA deleted the cwa/fix-104-use-custom-token-first branch February 7, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use custom token when possible
2 participants
@CasperWA @francescalb