-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ignore functionality (especially for 'version' rules) #140
Conversation
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 65.67% 71.61% +5.93%
==========================================
Files 9 9
Lines 472 546 +74
==========================================
+ Hits 310 391 +81
+ Misses 162 155 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good although update_deps.py
is (in my opinion) too long to understand and review efficiently. Perhaps it could be worth to clarify its central operational loop and move the logic functions into one or more separate files?
Also, Codecov generates a number of warnings about non-covered lines. Do these need to be addressed before merging?
Co-authored-by: Anders Eklund <96499163+ajeklund@users.noreply.github.com>
Co-authored-by: Anders Eklund <anders.eklund@sintef.no>
Completely fair. Edit: Opened #148
Right. I'll have a look at the lot of them and see how easy it would be to check some of the non-covered lines. |
I cannot come up with a case where TypeError would ever be raised.
I think I got most of the codecov messages now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Just one question added.
Minor is required to be present if patch is provided. Patch is required if either pre_release or build are provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #130
By extending the
SemanticVersion
class with rich comparison magic methods, the ignore rules for versions can be more easily checked.An extended test ensures some more specific ignore rules are respected as intended.
Dependency version ranges are still not properly respected.
For example if
>=1.0.0,<2
is specified, but the latest version is2.3.1
, then the result (with no ignore rules) will be>=2.3.1,<2
, which makes no sense.This should be remedied in another issue/PR.
Edit: This issue has now been reported in #141