Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sphinx #92

Merged
merged 14 commits into from
May 16, 2023
Merged

Support Sphinx #92

merged 14 commits into from
May 16, 2023

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Dec 7, 2022

Closes #90

Support building and deploying Sphinx-based documentation.

Implement Sphinx-framework in callable workflows:

  • CD - Release
  • CI - Tests
  • CI/CD - Updates to default branch

@CasperWA CasperWA marked this pull request as ready for review January 6, 2023 11:51
@CasperWA CasperWA requested a review from francescalb January 6, 2023 11:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #92 (e8006a6) into main (9dc7eb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files           9        9           
  Lines         472      472           
=======================================
  Hits          310      310           
  Misses        162      162           

@CasperWA CasperWA added the priority/medium Medium priority issue/PR label Mar 24, 2023
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things in here that seem to me to be outside the scope of this PR. That is fine, but makes is a little more difficult to review. Is there a way to preview how the documentation (of this PR) will change? That would be useful to review if I really understand how I can use this repo.

@CasperWA
Copy link
Collaborator Author

CasperWA commented May 15, 2023

There are some things in here that seem to me to be outside the scope of this PR. That is fine, but makes is a little more difficult to review. (...)

That's fair. I can try to split it up as best as I can, moving the out-of-scope stuff for another PR if

(...) Is there a way to preview how the documentation (of this PR) will change? That would be useful to review if I really understand how I can use this repo.

You can run it locally. There is a way to set it up so that a temporary documentation is created for each PR as well, but this requires using third-party services that are not setup for this repository (and would take more time than what is useful for now).

To run it locally do (ensuring you're in a virtual environment):

# Get the repository locally
git clone git@github.com:SINTEF/ci-cd.git
cd ci-cd

# Checkout the PR branch
git checkout cwa/close-90-support-sphinx-docs

# Install ci-cd with tools for running the documentation
pip install -U pip setuptools wheel flit
pip install -U -e .[docs]

# Build and run a local server with the documentation
mkdocs serve

Then go to the URL written to your terminal after the last command.

@francescalb
Copy link
Contributor

There are some things in here that seem to me to be outside the scope of this PR. That is fine, but makes is a little more difficult to review. (...)

That's fair. I can try to split it up as best as I can, moving the out-of-scope stuff for another PR if

(...) Is there a way to preview how the documentation (of this PR) will change? That would be useful to review if I really understand how I can use this repo.

You can run it locally. There is a way to set it up so that a temporary documentation is created for each PR as well, but this requires using third-party services that are not setup for this repository (and would take more time than what is useful for now).

To run it locally do (ensuring you're in a virtual environment):

# Get the repository locally
git clone git@github.com:SINTEF/ci-cd.git
cd ci-cd

# Checkout the PR branch
git checkout cwa/close-90-support-sphinx-docs

# Install ci-cd with tools for running the documentation
pip install -U pip setuptools wheel flit
pip install -U -e .[docs]

# Build and run a local server with the documentation
mkdocs serve

Then go to the URL written to your terminal after the last command.

Don't bother spending time on splitting up now. It was more a comment for the future :)
I'll look at ut locally, but I wan wionderling if there was a tool like git diff or something that would point me to where the documentation has changed. I'll look at it locally as you suggest.

@CasperWA CasperWA merged commit 4fecab2 into main May 16, 2023
@CasperWA CasperWA deleted the cwa/close-90-support-sphinx-docs branch May 16, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Medium priority issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Sphinx for documentation building
4 participants