Tem example

[jesper-friis]

Description

Example with OTEAPI and OTELib using TEM data.

This example currently depends on a set of other PRs:

• Support quoted relations in collection #633 (already merged into this branch)
• Added support for relative file paths EMMC-ASBL/oteapi-core#318
• Added support for lists in tripper.convert EMMC-ASBL/tripper#129
• Added a generic convert function strategy EMMC-ASBL/oteapi-dlite#163

Type of change

• Bug fix & code cleanup
• New feature
• Documentation update
• Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

• Is the change limited to one issue?
• Does this PR close the issue?
• Is the code easy to read and understand?
• Do all new feature have an accompanying new test?
• Has the documentation been updated as necessary?

[francescalb]

I have made some comments.

In particular I miss understanding of the changes to Dlite itself. I would like to re-review once the dependency PRs are approved, so that I can test as well.

Also, why have you added a dockerfile? I did not see any documentation on that and how to use it. (I think it is good to add it, but it wold be nice to document that in the README and not only working in a local env).

[francescalb]

Very nice demo. The demo.py script now works.

However, the some of the additional tests are not working. This does not show up here on github because the TEM-example is skipped in ctest. This is probably because the additional requirements are not included in the requirments_dev. Make sure to include the versions as well. Then it should not be necessary to have a requirements.txt inside the tem-demo. If you want to keep it, please add the versions.

So, before merging, please make sure that

1. TEM-demo is run as part of the ctest.
2. Tests are passing.
3. Tests that are not specific for the TEM-demo are moved out into a separate issue that can be resolved independently.
4. Versions are included in requirements.

[jesper-friis]

I have made some comments.

In particular I miss understanding of the changes to Dlite itself. I would like to re-review once the dependency PRs are approved, so that I can test as well.

Also, why have you added a dockerfile? I did not see any documentation on that and how to use it. (I think it is good to add it, but it wold be nice to document that in the README and not only working in a local env).

Removed the docker-compose file for now, since it is not currently used.

[jesper-friis]

Very nice demo. The demo.py script now works.

However, the some of the additional tests are not working. This does not show up here on github because the TEM-example is skipped in ctest. This is probably because the additional requirements are not included in the requirments_dev. Make sure to include the versions as well. Then it should not be necessary to have a requirements.txt inside the tem-demo. If you want to keep it, please add the versions.

So, before merging, please make sure that

1. TEM-demo is run as part of the ctest.
2. Tests are passing.
3. Tests that are not specific for the TEM-demo are moved out into a separate issue that can be resolved independently.
4. Versions are included in requirements.

Response:

1. Addressed in issue Add test for TEM example #655. This is much easier to implement when this PR has been accepted and released.
2. The tests passes locally for me.
3. Will be done in issue Add test for TEM example #655.
4. Done