Support latest DLite version (v0.5.16) #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a requirement for DLite v0.5.16
When/If DLite is installed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 27 27
Lines 1373 1373
=======================================
Hits 1266 1266
Misses 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Treesarj
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
The latest version support Python 3.12.
Furthermore, it seems to require NumPy
v2v1(at least for Python versions lower than 3.12).Indeed, after a bit of testing, it seems while the latest DLite version now supports Python 3.12, it does not support the latest NumPy version (v2).
There is currently now way of ensuring that if one installs DLite on a system alongside entity-service, NumPy will also stay at v1. However, it may be nice to add this to the README?
Edit: A note has been added to the README in this PR.