Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to create cache directory on each CLI call #87

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

CasperWA
Copy link
Collaborator

Fixes #82

As part of calling the CLI and loading/setting the global configuration options, the cache directory is created if it does not already exist.
If, for some reason, PermissionError is raised, i.e., if the user does not have the correct permissions to create folders in their own home folder, an appropriate error message will be written back to the user.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a91cba) 90.98% compared to head (f99d75a) 89.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   90.98%   89.70%   -1.28%     
==========================================
  Files          17       17              
  Lines         976      981       +5     
==========================================
- Hits          888      880       -8     
- Misses         88      101      +13     
Flag Coverage Δ
docker ?
local 89.70% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA requested review from Treesarj and francescalb and removed request for Treesarj and daniel-sintef February 13, 2024 07:05
Copy link

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely

@CasperWA CasperWA enabled auto-merge (squash) February 13, 2024 11:00
@CasperWA CasperWA merged commit 3a980c5 into main Feb 13, 2024
10 of 11 checks passed
@CasperWA CasperWA deleted the cwa/fix-82-cache-dir-creation branch February 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The cache dir is not being created automatically
2 participants