-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DLite #109
Support DLite #109
Conversation
Minor code base fixes: - Fix documentation rendering for lists in API doc-strings. - Update end2end_test.py according to updated dev tools guidelines. Concerning mypy. Pydantic v1 and mypy are not being updated properly. The latest working version of mypy with Pydantic v1 is v1.0.1, hence, mypy should henceforth be fixed to this version. See pydantic/pydantic#5192 for more information.
… cwa/close-31-support-dlite
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 72.95% 76.19% +3.24%
==========================================
Files 14 15 +1
Lines 514 605 +91
==========================================
+ Hits 375 461 +86
- Misses 139 144 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Trying to install oteapi-optimade results in the following dependency conflict
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-compose is not a dependency of this repository. As the CI jobs install the package and run fine, this seems to be a local problem for you. Please run in a closed environment when testing, e.g., a virtual environment or Docker. |
Also, align the version to be the same.
Closes #31
Implement support for DLite with a custom parse strategy and an extension of the existing resource strategy.
To use the resource strategy with DLite, simply add
+dlite
or+DLite
to theaccessService
. One can also setconfiguration.use_dlite
toTrue
.The custom parse strategy uses
+dlite
and+DLite
instead of+json
or+JSON
in themediaType
.Some simple tests have been added to ensure a DLite Collection object is created under the right circumstances.
A more in-depth test should be performed to check the parsed structure objects, however, the current tests are enough to test no errors occur during parsing and creation of DLite Instances for each OPTIMADE structure entry.