Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate classification module from standard dependencies #146

Closed
emlynjdavies opened this issue Oct 8, 2023 · 0 comments · Fixed by #149
Closed

Separate classification module from standard dependencies #146

emlynjdavies opened this issue Oct 8, 2023 · 0 comments · Fixed by #149
Labels
dependencies Pull requests that update a dependency file patch / enhancement improved functionality or patch indented for changes that require bumping only the PATCH number

Comments

@emlynjdavies
Copy link
Collaborator

emlynjdavies commented Oct 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
tensorflow is a large and often not needed package if classification of particles isn't needed. there is also not currently support for tensorflow-cpu on Mac M1 or M2 (must use tensorflow-macos for this instead)

Describe the solution you'd like
make dependencies associated with the classification module, an extra set of dependencies that are not installed by default.

Additional context
see Dependency groups in poetry
@emlynjdavies emlynjdavies added patch / enhancement improved functionality or patch indented for changes that require bumping only the PATCH number dependencies Pull requests that update a dependency file labels Oct 8, 2023
@emlynjdavies emlynjdavies linked a pull request Oct 8, 2023 that will close this issue
146 separate classification module from standard dependencies #149
Merged
@emlynjdavies emlynjdavies mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file patch / enhancement improved functionality or patch indented for changes that require bumping only the PATCH number
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

146 separate classification module from standard dependencies SINTEF/pyopia
1 participant
@emlynjdavies