-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
146 separate classification module from standard dependencies #149
Merged
emlynjdavies
merged 16 commits into
main
from
146-separate-classification-module-from-standard-dependencies
Dec 6, 2023
Merged
146 separate classification module from standard dependencies #149
emlynjdavies
merged 16 commits into
main
from
146-separate-classification-module-from-standard-dependencies
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlynjdavies
added
documentation
Improvements or additions to documentation
patch / enhancement
improved functionality or patch indented for changes that require bumping only the PATCH number
labels
Oct 9, 2023
nepstad
reviewed
Dec 6, 2023
nepstad
approved these changes
Dec 6, 2023
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
patch / enhancement
improved functionality or patch indented for changes that require bumping only the PATCH number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates optional dependencies for tensorflow, which are only needed for the Classification module.
Now, if the
[steps.classify]
step is not defined in the pipeline, particle classification is skipped and no probabilities are reported. This is implemented in a backwards-compatible way, and which allows pipelines to be run without a tensorflow installation when classification is not needed.New installation option:
The installation of the classification dependencies can be done with:
or (for Apple silicon)
After deployment (merging), this will be:
or (for Apple silicon)
Other changes