Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new workflow example #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding new workflow example #2

wants to merge 2 commits into from

Conversation

tviuff
Copy link
Collaborator

@tviuff tviuff commented Nov 8, 2022

No description provided.

@tviuff tviuff requested a review from lassebje November 8, 2022 09:53
@lassebje
Copy link
Collaborator

@tviuff Dette ser bra ut! Beklager at jeg har brukt så lang tid på review av denne.. Jeg har squashet commitene dine og lagt til noen kosmetiske endringer på toppen.
En ting jeg likevel ønsker meg. I stedet for at man endrer workflowset-filename på settet direkte så kan man heller bruke sima relativ path. sima://StorageTask\workflow_task_mod.json. Da slipper man å endre datamodellen

if workflow.name == workflow_name:
# Assume its the first item (nodes[0]) inside workflow, which is the workflow set
node: WorkflowSetNode = workflow.nodes[0]
node.filename = workflow_input_file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref. kommentar. Dette er ikke nødvendig om man bruker sima://-konvensjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants