-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to be root for pcapplay. #57
base: master
Are you sure you want to change the base?
Conversation
Ok. And pushing along, the second part got appended to this pull request too. Oh, well. That was the intention anyway. |
Looks good, thanks! I'd like to compile this and kick the tyres myself before I merge, but I should get to that this week. What OSes have you tested this on? I have Linux, OS X, Cygwin and FreeBSD available to me, and it probably makes sense for me to test on the ones you haven't been able to. |
Only tested on Linux. Similar changes have been running for a longer while on the sipp-osso hg fork, but those too have only been seen by a Linux OS. Cheers, (Excuse the short msg. This was composed on a phone...) Rob Day notifications@github.com wrote: Looks good, thanks! I'd like to compile this and kick the tyres myself before I merge, but I should get to that this week. What OSes have you tested this on? I have Linux, OS X, Cygwin and FreeBSD available to me, and it probably makes sense for me to test on the ones you haven't been able to. — |
I believe this has one issue: if you're using RTCP and/or other data over multiple ports, this does not work. Not sure how to proceed.
Both have disadvantages:
|
Sorry for the delay - had to mull that issue over. I think the right thing to do is to open the necessary range of ports - but we should do that at the very start (by checking the pcap files, seeing how many unique port numbers there are, and opening that many at the right offsets from the "base" port). If we fail to open one, we can just choose another "base" port and retry. |
bebdf78
to
8923379
Compare
Another option is to set CAP_NET_RAW on sipp. |
An interesting option, but it has its own drawbacks. I tried it indeed:
But that broke my unittest framework, which introspects which sockets are open by looking at proc:
|
Your personal unittest stuff Linux? Maybe |
Same difference:
Vs:
Was to be expected ;) |
Yeah, huh. TIL. |
231edd4
to
341fb97
Compare
Interestingly, the polycom-sipped also did some work on this, seeing that the RAW sockets changed to DGRAM in this commit: |
hi, is there any update on this PR? |
The first part, needed to get pcapplay without root powers going.