Release 0.0.16 #181
Merged
Release 0.0.16 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.2 to 17.4.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.3.2...v17.4.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rosoft.NET.Test.Sdk-17.4.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases) - [Commits](nunit/nunit3-vs-adapter@V4.3.0...V4.3.1) --- updated-dependencies: - dependency-name: NUnit3TestAdapter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…it3TestAdapter-4.3.1
Bumps [HIC.BadMedicine](https://github.com/HicServices/BadMedicine) from 1.1.1 to 1.1.2. - [Release notes](https://github.com/HicServices/BadMedicine/releases) - [Changelog](https://github.com/HicServices/BadMedicine/blob/develop/CHANGELOG.md) - [Commits](HicServices/SynthEHR@v1.1.1...v1.1.2) --- updated-dependencies: - dependency-name: HIC.BadMedicine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….BadMedicine-1.1.2
Add CodeQL workflow for GitHub code scanning
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 12.0.2 to 12.1.0. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v12.0.2...v12.1.0) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lDotNet-12.1.0
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 12.1.0 to 12.2.0. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v12.1.0...v12.2.0) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lDotNet-12.2.0
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 12.2.0 to 12.2.1. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v12.2.0...v12.2.1) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…lDotNet-12.2.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.0 to 17.4.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.4.0...v17.4.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…rosoft.NET.Test.Sdk-17.4.1
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 12.2.1 to 12.3.1. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v12.2.1...v12.3.1) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lDotNet-12.3.1
Bumps [HIC.DicomTypeTranslation](https://github.com/HicServices/DicomTypeTranslation) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/HicServices/DicomTypeTranslation/releases) - [Changelog](https://github.com/HicServices/DicomTypeTranslation/blob/main/CHANGELOG.md) - [Commits](SMI/DicomTypeTranslation@4.0.1...v4.0.2) --- updated-dependencies: - dependency-name: HIC.DicomTypeTranslation dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….DicomTypeTranslation-4.0.2
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.2 to 17.6.3. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.6.2...v17.6.3) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ET.Test.Sdk-17.6.3 Bump Microsoft.NET.Test.Sdk from 17.6.2 to 17.6.3
Bumps [NunitXml.TestLogger](https://github.com/spekt/nunit.testlogger) from 3.0.131 to 3.1.15. - [Release notes](https://github.com/spekt/nunit.testlogger/releases) - [Changelog](https://github.com/spekt/nunit.testlogger/blob/master/CHANGELOG.md) - [Commits](spekt/nunit.testlogger@v3.0.131...v3.1.15) --- updated-dependencies: - dependency-name: NunitXml.TestLogger dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…stLogger-3.1.15
Bumps [XunitXml.TestLogger](https://github.com/spekt/xunit.testlogger) from 3.0.78 to 3.1.11. - [Release notes](https://github.com/spekt/xunit.testlogger/releases) - [Changelog](https://github.com/spekt/xunit.testlogger/blob/master/CHANGELOG.md) - [Commits](spekt/xunit.testlogger@v3.0.78...v3.1.11) --- updated-dependencies: - dependency-name: XunitXml.TestLogger dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…stLogger-3.1.11
Bumps [svenstaro/upload-release-action](https://github.com/svenstaro/upload-release-action) from 2.6.1 to 2.7.0. - [Release notes](https://github.com/svenstaro/upload-release-action/releases) - [Changelog](https://github.com/svenstaro/upload-release-action/blob/master/CHANGELOG.md) - [Commits](svenstaro/upload-release-action@2.6.1...2.7.0) --- updated-dependencies: - dependency-name: svenstaro/upload-release-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.3 to 17.7.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.6.3...v17.7.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 1.0.0-beta15 to 1.0.0. - [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases) - [Commits](SixLabors/ImageSharp.Drawing@v1.0.0-beta15...v1.0.0) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp.Drawing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 13.1.1 to 13.2.0. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v13.1.1...v13.2.0) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.0 to 17.7.2. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.7.0...v17.7.2) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 13.2.0 to 13.3.1. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v13.2.0...v13.3.1) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ET.Test.Sdk-17.7.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [SixLabors.ImageSharp](https://github.com/SixLabors/ImageSharp) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/SixLabors/ImageSharp/releases) - [Commits](SixLabors/ImageSharp@v3.0.1...v3.0.2) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 1.0.0 to 2.0.0. - [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases) - [Commits](SixLabors/ImageSharp.Drawing@v1.0.0...v2.0.0) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp.Drawing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [XunitXml.TestLogger](https://github.com/spekt/xunit.testlogger) from 3.1.11 to 3.1.17. - [Release notes](https://github.com/spekt/xunit.testlogger/releases) - [Changelog](https://github.com/spekt/xunit.testlogger/blob/master/CHANGELOG.md) - [Commits](spekt/xunit.testlogger@v3.1.11...v3.1.17) --- updated-dependencies: - dependency-name: XunitXml.TestLogger dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+179
to
+184
| catch (Exception e) | ||
| { | ||
| Console.WriteLine($"Could not reach target server '{server.Name}'"); | ||
| Console.WriteLine(e); | ||
| return -2; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+141
to
+308
| } | ||
|
|
||
| Console.WriteLine($"Creating uploader for '{tbl.GetRuntimeName()}''"); | ||
| var create = true; | ||
|
|
||
| for (int j = 0; j < batchSize; j++) | ||
| if (tbl.Exists()) | ||
| { | ||
| if (configDatabase.DropTables) | ||
| { | ||
| //fetch schema | ||
| var dt = tbl.GetDataTable(); | ||
| dt.Rows.Clear(); | ||
|
|
||
| batches[j][i] = dt; | ||
| uploaders[j][i] = tbl.BeginBulkInsert(); | ||
| Console.WriteLine($"Dropping existing table '{tbl.GetFullyQualifiedName()}'"); | ||
| tbl.Drop(); | ||
| } | ||
| else | ||
| { | ||
| Console.WriteLine($"Table '{tbl.GetFullyQualifiedName()}' already existed (so will not be created)"); | ||
| create = false; | ||
| } | ||
| } | ||
| var tasks = new Task[batchSize]; | ||
|
|
||
| IPersonCollection identifiers = GetPeople(opts, out Random r); | ||
|
|
||
| if(create) | ||
| { | ||
| Console.WriteLine($"About to create '{tbl.GetFullyQualifiedName()}'"); | ||
| creator.CreateTable(tbl, tableSchema); | ||
| Console.WriteLine($"Successfully created create '{tbl.GetFullyQualifiedName()}'"); | ||
| } | ||
|
|
||
| for (int i = 0; i < batchSize; i++) | ||
| Console.WriteLine($"Creating uploader for '{tbl.GetRuntimeName()}''"); | ||
|
|
||
| for (var j = 0; j < batchSize; j++) | ||
| { | ||
| var batch = i; | ||
| tasks[i] = new(() => // lgtm[cs/local-not-disposed] | ||
| { | ||
| RunBatch(identifiers,opts,r,batches[batch],uploaders[batch]); | ||
| //fetch schema | ||
| var dt = tbl.GetDataTable(); | ||
| dt.Rows.Clear(); | ||
|
|
||
| }); | ||
| tasks[i].Start(); | ||
| batches[j][i] = dt; | ||
| uploaders[j][i] = tbl.BeginBulkInsert(); | ||
| } | ||
| } | ||
| var identifiers = GetPeople(opts, out var r); | ||
|
|
||
| Task.WaitAll(tasks); | ||
| Parallel.For(0, batchSize, i => RunBatch(identifiers, opts, r, batches[i], uploaders[i])); | ||
|
|
||
| swTotal.Stop(); | ||
| swTotal.Stop(); | ||
|
|
||
| for (var i = 0; i < tables.Length; i++) | ||
| { | ||
| if(pks[i] == null) | ||
| continue; | ||
| for (var i = 0; i < tables.Length; i++) | ||
| { | ||
| if(pks[i] == null) | ||
| continue; | ||
|
|
||
| Console.WriteLine( $"{DateTime.Now} Making table '{tables[i]}' distinct (this may take a long time)"); | ||
| var tbl = tables[i]; | ||
| tbl.MakeDistinct(500000000); | ||
| Console.WriteLine( $"{DateTime.Now} Making table '{tables[i]}' distinct (this may take a long time)"); | ||
| var tbl = tables[i]; | ||
| tbl.MakeDistinct(500000000); | ||
|
|
||
| Console.WriteLine( $"{DateTime.Now} Creating primary key on '{tables[i]}' of '{pks[i]}'"); | ||
| tbl.CreatePrimaryKey(500000000,tbl.DiscoverColumn(pks[i])); | ||
| } | ||
| Console.WriteLine( $"{DateTime.Now} Creating primary key on '{tables[i]}' of '{pks[i]}'"); | ||
| tbl.CreatePrimaryKey(500000000,tbl.DiscoverColumn(pks[i])); | ||
| } | ||
|
|
||
| Console.WriteLine("Final Row Counts:"); | ||
| Console.WriteLine("Final Row Counts:"); | ||
|
|
||
| foreach (DiscoveredTable t in tables) | ||
| Console.WriteLine($"{t.GetFullyQualifiedName()}: {t.GetRowCount():0,0}"); | ||
| foreach (var t in tables) | ||
| Console.WriteLine($"{t.GetFullyQualifiedName()}: {t.GetRowCount():0,0}"); | ||
|
|
||
| Console.WriteLine($"Total Running Time:{swTotal.Elapsed}"); | ||
| return 0; | ||
| } | ||
| Console.WriteLine($"Total Running Time:{swTotal.Elapsed}"); | ||
| return 0; | ||
| } |
Check notice
Code scanning / CodeQL
Block with too many statements
Comment on lines
+66
to
+71
| catch (Exception e) | ||
| { | ||
| Console.WriteLine($"Error deserializing '{ConfigFile}'{Environment.NewLine}{e}"); | ||
| _returnCode = -1; | ||
| return; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+162
to
+166
| catch (Exception e) | ||
| { | ||
| Console.WriteLine($"Error reading yaml from '{configDatabase.Template}'{Environment.NewLine}{e}"); | ||
| return -2; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
JFriel
approved these changes
Oct 4, 2023
rkm
approved these changes
Oct 4, 2023
No major blockers, maybe fix one or two of the outstanding issues before calling it v1.0 though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency updates and syntax cleanups