Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple CLI for testing message sending #1520

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

rkm
Copy link
Member

@rkm rkm commented Apr 16, 2023

Proposed Changes

Summarise your proposed changes here, including any notes for reviewers.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: -0.14 ⚠️

Comparison is base (a0903dc) 67.94% compared to head (3de3ebe) 67.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   67.94%   67.81%   -0.14%     
==========================================
  Files         185      186       +1     
  Lines        6546     6553       +7     
==========================================
- Hits         4448     4444       -4     
- Misses       2098     2109      +11     
Impacted Files Coverage Δ
...lications.ServiceTester/ServiceTesterCliOptions.cs 0.00% <0.00%> (ø)
...rc/common/Smi.Common/Messages/FatalErrorMessage.cs 0.00% <0.00%> (ø)
src/applications/Applications.SmiRunner/Program.cs 33.82% <50.00%> (+0.49%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant