Feature/packagesmd #384
Merged
Feature/packagesmd #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkm
reviewed
Sep 9, 2020
| @@ -118,10 +118,6 @@ public void TestDependencyCorrect(string csproj, string nuspec, string packagesM | |||
| if (Regex.IsMatch(line, @"[\s[]" + Regex.Escape(package) + @"[\s\]]", RegexOptions.IgnoreCase)) | |||
| { | |||
| int count = new Regex(Regex.Escape(version)).Matches(line).Count; | |||
There was a problem hiding this comment.
This line can probably be removed as well?
rkm
approved these changes
Sep 9, 2020
jas88
approved these changes
Sep 9, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Summarise your changes, and include a link to the CHANGELOG diff.
Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]Checklist
By opening this PR, I confirm that I have:
Issues
If relevant, tag any issues that are expected to be resolved with this PR. E.g.:
\fixes #64