Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/config injection #385

Merged
merged 13 commits into from
Sep 11, 2020
Merged

Feature/config injection #385

merged 13 commits into from
Sep 11, 2020

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Sep 9, 2020

Proposed Changes

  • Removes the requirement to have environment variables (they are still respected if present though).
  • Refactoring to improve extensibility of config files secrets

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

\fixes #382

@tznind tznind marked this pull request as ready for review September 9, 2020 11:08
@tznind tznind requested review from rkm and jas88 September 9, 2020 11:08
# Conflicts:
#	src/common/Smi.Common/Options/Microservices.Common.Options.cd
@tznind
Copy link
Contributor Author

tznind commented Sep 11, 2020

Thanks for reviewing the changes @rkm. I see you madeSetMongoPassword and GlobalOptions.ForAll static, was that deliberate? They are not accessed from a static context.

@rkm
Copy link
Member

rkm commented Sep 11, 2020

I don't mind either way to be honest, it was suggested by resharper though and looks to be valid since they don't access instance variables at all?

@tznind
Copy link
Contributor Author

tznind commented Sep 11, 2020

I don't mind either way to be honest, it was suggested by resharper though and looks to be valid since they don't access instance variables at all?

Ah ok, I think I will undo it. Not a fan of making stuff static without a good reason. It often gets in the way later on.

@tznind tznind merged commit bc1c427 into develop Sep 11, 2020
@tznind tznind deleted the feature/config-injection branch September 11, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants