-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/config injection #385
Conversation
# Conflicts: # src/common/Smi.Common/Options/Microservices.Common.Options.cd
Thanks for reviewing the changes @rkm. I see you made |
I don't mind either way to be honest, it was suggested by resharper though and looks to be valid since they don't access instance variables at all? |
Ah ok, I think I will undo it. Not a fan of making stuff static without a good reason. It often gets in the way later on. |
Proposed Changes
Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]
Checklist
By opening this PR, I confirm that I have:
Issues
If relevant, tag any issues that are expected to be resolved with this PR. E.g.:
\fixes #382