Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reject multiple #388

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Feature/reject multiple #388

merged 3 commits into from
Sep 11, 2020

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Sep 11, 2020

Proposed Changes

Changes config option RejectPatientsIn into RejectColumnInfos and allows for referencing multiple columns. This would let us have a secondary forbid table that blocks e.g. by StudyInstanceUID like where OCR has found problematic data in the files.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

@tznind tznind requested a review from rkm September 11, 2020 07:41
@tznind tznind merged commit 80e2a49 into develop Sep 11, 2020
@tznind tznind deleted the feature/reject-multiple branch September 11, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants