Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction: RejectReason check #391

Merged
merged 6 commits into from
Sep 14, 2020
Merged

Extraction: RejectReason check #391

merged 6 commits into from
Sep 14, 2020

Conversation

rkm
Copy link
Member

@rkm rkm commented Sep 14, 2020

Proposed Changes

Added a check to QueryToExecuteResult for RejectReason being null when Reject is true.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm requested a review from tznind September 14, 2020 09:58
@rkm rkm self-assigned this Sep 14, 2020
@rkm rkm changed the title Feature/extraction fixes Extraction: RejectReason check Sep 14, 2020
@tznind tznind removed their request for review September 14, 2020 11:38
@rkm rkm requested a review from 2bPro September 14, 2020 11:39
@2bPro 2bPro closed this Sep 14, 2020
@2bPro 2bPro reopened this Sep 14, 2020
@2bPro 2bPro merged commit 6af90b8 into develop Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants