Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved badges to same line and added Setup section #935

Merged
merged 6 commits into from
Oct 29, 2021
Merged

Moved badges to same line and added Setup section #935

merged 6 commits into from
Oct 29, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Oct 19, 2021

Proposed Changes

Fixes #920

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

@coveralls
Copy link

coveralls commented Oct 19, 2021

Coverage Status

Coverage remained the same at 51.846% when pulling 8048e94 on setup-docs into c603ff4 on master.

@tznind tznind marked this pull request as ready for review October 29, 2021 08:28
@tznind tznind requested a review from rkm October 29, 2021 08:28
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@tznind tznind requested a review from rkm October 29, 2021 10:24
@rkm
Copy link
Member

rkm commented Oct 29, 2021

You managed to cause a segfault in dotnet by updating the README - congrats! 😄

subprocess.CalledProcessError: Command '('dotnet', 'test', '/p:Platform=x64', '--configuration=Release', '--verbosity=Normal', '--no-build', '--settings=data/nunit.runsettings', PosixPath('tests/common/Smi.Common.MongoDb.Tests/Smi.Common.MongoDb.Tests.csproj'), '/p:CollectCoverage=true', '/p:CoverletOutput="/home/vsts/work/1/s/coverage/"', '/p:MergeWith="/home/vsts/work/1/s/coverage/coverage.json"', '/p:Exclude="[*.Tests]*"')' died with <Signals.SIGSEGV: 11>.

I've restarted the check, so just merge when it passes.

@rkm rkm merged commit c39b84d into master Oct 29, 2021
@rkm rkm deleted the setup-docs branch October 29, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Deployment section of readme
3 participants