Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Download, unpack solver and test solver on dumb test file #58

Merged
merged 2 commits into from
May 29, 2024

Conversation

bobot
Copy link
Contributor

@bobot bobot commented May 27, 2024

No description provided.

@bobot bobot changed the title [CI] Download, unpack solver and generate a dumb test script [CI] Download, unpack solver and test solver on dumb test file May 27, 2024
@bobot bobot force-pushed the ci-test-solver branch 4 times, most recently from 8ebfb27 to c09c23c Compare May 27, 2024 10:02
@bobot
Copy link
Contributor Author

bobot commented May 27, 2024

@martinjonas Currently it is executing the solver using subprocess.run but in the docker of the cluster, do you think we can execute it really as it will be executed in the cluster?

@bobot bobot force-pushed the ci-test-solver branch 6 times, most recently from c55d307 to afb2e67 Compare May 28, 2024 11:40
@martinjonas
Copy link
Contributor

@martinjonas Currently it is executing the solver using subprocess.run but in the docker of the cluster, do you think we can execute it really as it will be executed in the cluster?

Not exactly as it will be executed in the cluster (VerifierCloud is not public yet), but we can certainly execute it via BenchExec, but locally. This should be almost the same as in the cluster. Or, taking one more step back, we can execute it using runexec (https://github.com/sosy-lab/benchexec/blob/main/doc/runexec.md), which is the program that is used by BenchExec to execute the solvers and which takes care of isolation, resource limits and resource measurement.

But I am not sure whether the change is worth it. If the solver can be executed in the docker container, it is very likely that it can be executed also using BenchExec (if our BenchExec configuration files are correct).

@bobot
Copy link
Contributor Author

bobot commented May 29, 2024

runexec can even be used through API, https://github.com/sosy-lab/benchexec/blob/6467aa5e1117155586f50928c17097fa87f341de/doc/runexec.md?plain=1#L77 . The advantage is to also be able to parse the output like benchexec will do it. So we can really check that the solver answer sat (as parsed by benchexec) on trivial sat examples.

@bobot
Copy link
Contributor Author

bobot commented May 29, 2024

benchexec and runexecutor are not installed in the image, so we will parse normally.

@bobot bobot force-pushed the ci-test-solver branch from d503736 to 823d3d3 Compare May 29, 2024 14:54
@bobot bobot force-pushed the ci-test-solver branch from 823d3d3 to caa56fd Compare May 29, 2024 14:57
@bobot bobot merged commit 2f600c3 into SMT-COMP:master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants